Choose timezone
Your profile timezone:
Powered by Indico
v3.3.5
We have a Code Approval Procedure in place for merge requests; the bottleneck at the moment is the code review. Code review can (and should) be done by everybody actively developing. Once the review is over, the label "Ready to merge" is added; currently, the one merging is always Maximilian Reininghaus.
Christian Glaser suggests (from experience in NuRadioMC), that the one to merge a pull request would be the author. Also in NuRadioMC, an embargo period of 24 h between approving and merging is observed.
Lukas reminds, that not all pipelines are triggered automatically. These should be run by the developer before the code review, so that the reviewer sees the result of these pipelines.
The developer can assign people to act as reviewer, which is encouraged. Rebasing the code, if needed, is responsibility of the developer; if merge conflicts outside of the files directly affected by the branch appear, use git blame to find out who can help.
We are looking for volunteers to have a look on the TAUOLA branch which Remy developed a long time ago, that did not get merged; Fan Hu agreed to rebase it and look for merge conflicts.
Authors of open issues should look at their own issues and decide, whether the problem still persists. What to do with issues by members, who have been inactive for a long time, will be discussed later (after the Auger meeting).
Lukas mentions one problem with clang-format: The result appears to be version-dependent. It was agreed to check how many lines are affected by these changes to decide whether this is a major problem.
Max mentions that coverage jobs in CI are currently failing. Lukas will look into this later.